GitList
Repositories
Help
Report an Issue
vroom360
Code
Commits
Branches
Tags
Search
Tree:
e36c40f
Branches
Tags
master
vroom360
ezcMail
Mail
review-1.7.txt
initial commit
Dev Ghai
commited
e36c40f
at 2013-09-26 06:24:15
review-1.7.txt
Blame
History
Raw
ezcMailPartParser ================= [x] The function parseHeader() should be refactored. The new code has in the if() and elseif() case duplicated code that can easily be extracted into a new private method. The code is too coupled and the private function will have 4-5 params. It applies to only 4 lines of code. The solution which I tried actually looks worse than what it is now. [x] The test in trunk/Mail/tests/composer_test.php should removed the added check for "charset=binary" as that is a bug in PHP (line 647ish) [ ] From reading the code, I don't think that it is possible to use headers with the same name while creating mail as well. This needs to be supported so that mails can be forwarded with all current headers in tact. We'd need to add tests for both generation and forwarding/replying here.
